Hardpoint UI Fixes #416
Merged
Hardpoint UI Fixes #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed not showing Auto-Titans death in killfeed
|
Is there a chance that this is an underlying problem with sh_consts or something? Maybe we are missing another CAPTURE_POINT_STATE somehow? |
Could be, otherwise I have no clue how this works. Past the number 8, every subsequent even number would put it back to normal "Amping _%" but every odd number puts it back to "CONTESTED". Wouldn't surprise me if its just a random number since the |
EladNLG
approved these changes
Jul 20, 2022
GeckoEidechse
added
needs testing
ASpoonPlaysGames
approved these changes
Oct 7, 2022
EladNLG
requested changes
Nov 20, 2022
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_cp.nut
Outdated
Show resolved
Hide resolved
NoCatt
approved these changes
Mar 2, 2023
GeckoEidechse
added
almost ready to merge
|
Merging as soon as I get a recent code review ^^ |
for like one line the rest of the file is kinda oof tho but not related to my pr
EladNLG
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
I like when the playerHardpointID is 69 :)
Anyways, took a look over everything, and it looks good - no real complaints.
We should, however, turn the SetHardpointState( hardpoint, 8 ) thing into an issue because I will not accept hacks in my Titanfall 2 Northstar mod >:(((
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_cp.nut
Outdated
Show resolved
Hide resolved
Northstar.CustomServers/mod/scripts/vscripts/gamemodes/_gamemode_cp.nut
Outdated
Show resolved
Hide resolved
|
(gecko I forgot to remove the conversations i cannot delete them please dont hurt me) |
GeckoEidechse
removed
needs code review
GeckoEidechse
approved these changes
Mar 9, 2023
GeckoEidechse
pushed a commit
that referenced
this pull request
Apr 18, 2023
* fixed not showing Auto-Titans death in killfeed * bug fix * Hardpoint Fixes
pg9182
reviewed
Apr 19, 2023
There was a problem hiding this comment.
Crashed when applied on 1.12 and testing with just myself in private match / cp / mp_colony02:
[22:34:11] [NATIVE SV] [info] Player pg9182 fully connected at time 5.73333
[22:34:11] [SCRIPT SV] [info] Player client script initialization complete: entity (1: player pg9182 [1])
[22:34:11] [SCRIPT SV] [info] ############################
[22:34:11] [SCRIPT SV] [info] CommandString: ClientStatus was not added via AddClientCommandCallback but is being called in CodeCallback_ClientCommand
[22:34:11] [SCRIPT SV] [info] ############################
[22:34:11] [SCRIPT SV] [info] ############################
[22:34:11] [SCRIPT SV] [info] CommandString: AllDialogueFinished was not added via AddClientCommandCallback but is being called in CodeCallback_ClientCommand
[22:34:11] [SCRIPT SV] [info] ############################
[22:34:11] [NATIVE SV] [info] Setting player "player pg9182 [1]" predicted first person proxy model to "" (class "spectator")
[22:34:11] [SCRIPT SV] [info] done waiting!
[22:34:12] [SCRIPT SV] [info] started intro!
[22:34:12] [SCRIPT SV] [info] starting dropship intro!
[22:34:12] [SCRIPT SV] [info] SCRIPT ERROR: [SERVER] Entity class "CNPC_Dropship" doesn't match required class for this index or function call
[22:34:12] [SCRIPT SV] [info] -> player.SetPlayerNetInt( "playerHardpointID", hardpoint.hardpoint.GetHardpointID() )
[22:34:12] [SCRIPT SV] [info]
CALLSTACK
*FUNCTION [OnHardpointEntered()] gamemodes/_gamemode_cp.nut line [654]
[22:34:12] [SCRIPT SV] [info] LOCALS
[hardpoint] unknown struct
[player] ENTITY (npc_dropship [128] (NPC "npc_dropship" at <933.302 -1869.51 314.585>))
[trigger] ENTITY (trigger_capture_point trigger_hardpoint_c [203] at <1404 -1940 476>)
[this] TABLE
DIAGPRINTS
Doesn't crash before this PR.
GeckoEidechse
added a commit
that referenced
this pull request
Apr 19, 2023
This reverts commit 28d444c. As it causes crash as explained in #416 (review)
GeckoEidechse
added a commit
that referenced
this pull request
Apr 19, 2023
This reverts commit 28d444c. As it causes crash as explained in #416 (review)
GeckoEidechse
added a commit
that referenced
this pull request
Apr 19, 2023
This reverts commit 28d444c. As it causes crash as explained in #416 (review)
GeckoEidechse
pushed a commit
that referenced
this pull request
Apr 22, 2023
* fixed not showing Auto-Titans death in killfeed * revert indents * revert indents again * bug fix * Hardpoint Fixes * "fixed" spacing for like one line the rest of the file is kinda oof tho but not related to my pr * 69 spacing * SetPlayerNetInt is placed inside a player entity check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
Methodology:
When using
SetHardpointState(CAPTURE_POINT_STATE_AMPING), the game will say that it is "CONTESTED" even though there's no enemy. The bar will still increase even though it said that its being contested.This is replaced with an arbitrary number of 8 which removes the "CONTESTED" UI bug.
This shouldn't affect the actual contested UI from being displayed as the code checks for contested zones first before displaying amping UI.